Merge branch 'master' of https://github.com/mathuo/dockview into 475-improved-docs

Author: mathuo

packages/dockview-core/src/api/dockviewGroupPanelApi.ts

@@ -16,6 +16,7 @@ export interface DockviewGroupPanelApi extends GridviewPanelApi {
     maximize(): void;
     isMaximized(): boolean;
     exitMaximized(): void;
+    close(): void;
 }
 
 export interface DockviewGroupPanelFloatingChangeEvent {
@@ -46,6 +47,13 @@ export class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
         this.addDisposables(this._onDidLocationChange);
     }
 
+    close(): void {
+        if (!this._group) {
+            return;
+        }
+        return this.accessor.removeGroup(this._group);
+    }
+
     getWindow(): Window {
         return this.location.type === 'popout'
             ? this.location.getWindow()

packages/dockview-core/src/dnd/droptarget.ts

@@ -333,7 +333,7 @@ export class Droptarget extends CompositeDisposable {
         } else if (topClass) {
             box.height = `${100 * size}%`;
         } else if (bottomClass) {
-            box.top = `${100 * size}%`;
+            box.top = `${100 * (1 - size)}%`;
             box.height = `${100 * size}%`;
         }
 

packages/dockview-core/src/dockview/dockviewComponent.ts

@@ -272,16 +272,25 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
     readonly activePanel: IDockviewPanel | undefined;
     readonly totalPanels: number;
     readonly panels: IDockviewPanel[];
+    readonly orientation: Orientation;
     readonly onDidDrop: Event<DockviewDidDropEvent>;
     readonly onWillDrop: Event<DockviewWillDropEvent>;
     readonly onWillShowOverlay: Event<WillShowOverlayLocationEvent>;
-    readonly orientation: Orientation;
+    readonly onDidRemovePanel: Event<IDockviewPanel>;
+    readonly onDidAddPanel: Event<IDockviewPanel>;
+    readonly onDidLayoutFromJSON: Event<void>;
+    readonly onDidActivePanelChange: Event<IDockviewPanel | undefined>;
+    readonly onWillDragPanel: Event<TabDragEvent>;
+    readonly onWillDragGroup: Event<GroupDragEvent>;
+    readonly onDidRemoveGroup: Event<DockviewGroupPanel>;
+    readonly onDidAddGroup: Event<DockviewGroupPanel>;
+    readonly onDidActiveGroupChange: Event<DockviewGroupPanel | undefined>;
+    readonly options: DockviewComponentOptions;
     updateOptions(options: DockviewComponentUpdateOptions): void;
     moveGroupOrPanel(options: MoveGroupOrPanelOptions): void;
     moveGroup(options: MoveGroupOptions): void;
     doSetGroupActive: (group: DockviewGroupPanel, skipFocus?: boolean) => void;
     removeGroup: (group: DockviewGroupPanel) => void;
-    options: DockviewComponentOptions;
     addPanel<T extends object = Parameters>(
         options: AddPanelOptions<T>
     ): IDockviewPanel;
@@ -299,12 +308,6 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
     toJSON(): SerializedDockview;
     fromJSON(data: SerializedDockview): void;
     //
-    readonly onDidRemovePanel: Event<IDockviewPanel>;
-    readonly onDidAddPanel: Event<IDockviewPanel>;
-    readonly onDidLayoutFromJSON: Event<void>;
-    readonly onDidActivePanelChange: Event<IDockviewPanel | undefined>;
-    readonly onWillDragPanel: Event<TabDragEvent>;
-    readonly onWillDragGroup: Event<GroupDragEvent>;
     addFloatingGroup(
         item: IDockviewPanel | DockviewGroupPanel,
         coord?: { x: number; y: number }
@@ -318,9 +321,6 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
             onWillClose?: (event: { id: string; window: Window }) => void;
         }
     ): Promise<void>;
-    readonly onDidRemoveGroup: Event<DockviewGroupPanel>;
-    readonly onDidAddGroup: Event<DockviewGroupPanel>;
-    readonly onDidActiveGroupChange: Event<DockviewGroupPanel | undefined>;
 }
 
 export class DockviewComponent
@@ -1847,7 +1847,7 @@ export class DockviewComponent
             const removedPanel: IDockviewPanel | undefined = this.movingLock(
                 () =>
                     sourceGroup.model.removePanel(sourceItemId, {
-                        skipSetActive: true,
+                        skipSetActive: false,
                         skipSetActiveGroup: true,
                     })
             );