Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
rocq-prover/rocq#19987 refolds terms before using them to instantiate evars. In
classical/functions.v
, there is a lemma (image_subP
) that useshomomorphism_1
, which introduces eta-expansions. Due to unfoldings in the previous algorithm, these eta-expansions were removed, whereas they are not now, which makesrewrite
's matching algorithm fail. Intheories/function_spaces
, there is a second order unification problem which is solved differently.Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers