synchronize (#457)

Co-authored-by: jongmin.jung <jongmin.jung@navercorp.com>
mash-up-kr · Aug 24, 2024 · 5442b2c · 5442b2c
1 parent 47955f0
commit 5442b2c
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/...p-member/src/main/java/kr/mashup/branding/facade/mashong/MashongMissionFacadeService.java b/...p-member/src/main/java/kr/mashup/branding/facade/mashong/MashongMissionFacadeService.java
@@ -32,16 +32,24 @@ public class MashongMissionFacadeService {
     public void apply(MissionStrategyType missionStrategyType, MemberGeneration memberGeneration, Double value) {
         MashongMission mission = mashongMissionService.findMissionByStrategyType(missionStrategyType);
         if (mission.getMissionType() == MissionType.INDIVIDUAL) {
-            MashongMissionLevel latestMissionLevel = getLatestMissionLevel(memberGeneration, mission);
-            MashongMissionLog mashongMissionLog = mashongMissionLogService.getMissionLog(latestMissionLevel, memberGeneration.getId());
-            mashongMissionLog.incrementCurrentStatus(value);
+            applyIndividual(memberGeneration, mission, value);
         } else {
-            MashongMissionLevel latestMissionLevel = getLatestMissionLevel(memberGeneration.getPlatform(), memberGeneration.getGeneration().getId(), mission);
-            MashongMissionTeamLog mashongMissionLog = mashongMissionTeamLogService.getMissionLog(latestMissionLevel, memberGeneration.getPlatform(), memberGeneration.getGeneration().getId());
-            mashongMissionLog.incrementCurrentStatus(value);
+            applyTeam(memberGeneration, mission, value);
         }
     }
 
+    private void applyIndividual(MemberGeneration memberGeneration, MashongMission mission, Double value) {
+        MashongMissionLevel latestMissionLevel = getLatestMissionLevel(memberGeneration, mission);
+        MashongMissionLog mashongMissionLog = mashongMissionLogService.getMissionLog(latestMissionLevel, memberGeneration.getId());
+        mashongMissionLog.incrementCurrentStatus(value);
+    }
+
+    synchronized private void applyTeam(MemberGeneration memberGeneration, MashongMission mission, Double value) {
+        MashongMissionLevel latestMissionLevel = getLatestMissionLevel(memberGeneration.getPlatform(), memberGeneration.getGeneration().getId(), mission);
+        MashongMissionTeamLog mashongMissionLog = mashongMissionTeamLogService.getMissionLog(latestMissionLevel, memberGeneration.getPlatform(), memberGeneration.getGeneration().getId());
+        mashongMissionLog.incrementCurrentStatus(value);
+    }
+
     @Transactional
     public void setToValue(MissionStrategyType missionStrategyType, MemberGeneration memberGeneration, Double value) {
         MashongMission mission = mashongMissionService.findMissionByStrategyType(missionStrategyType);