Skip to content

Commit

Permalink
Replaced from ... import * statements
Browse files Browse the repository at this point in the history
* as per ASKBOT#849 (comment)
* untested so far !
  • Loading branch information
martin-bts authored and martin-bts committed Jan 28, 2020
1 parent 935b8d7 commit fe1b221
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion askbot/deployment/deployables/components.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os

from .objects import *
from .objects import RenderedFile, CopiedFile, EmptyFile, Directory, LinkedDir
from askbot.deployment.base import DeployableComponent

"""The classes defined herein are what we want to do when we talk about
Expand Down
6 changes: 3 additions & 3 deletions askbot/deployment/parameters/__init__.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from askbot.deployment.base import ConfigManagerCollection, ConfigManager
from .configmanagers import CacheConfigManager, DbConfigManager

from .cache import *
from .database import *
from .filesystem import *
from .cache import CacheEngine, CacheNodes, CacheDb, CachePass
from .database import DbUser, DbPass, DbHost, DbPort, DbEngine, DbName
from .filesystem import LogfileName, BaseDirName, ProjectDirName, AppDirName

"""
In this module we assemble the input validation capabilities for the Askbot
Expand Down
4 changes: 3 additions & 1 deletion askbot/deployment/parameters/filesystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
from askbot.deployment import messages
from askbot.deployment.base import ConfigField
from askbot.deployment.path_utils import has_existing_django_project
from askbot.deployment.base.exceptions import *
from askbot.deployment.base.exceptions import DirNameError, RestrictionsError,\
NameCollisionError, IsFileError, CreateWriteError, NestedProjectsError,\
OverwriteError

DEBUG_VERBOSITY = 2

Expand Down
6 changes: 4 additions & 2 deletions askbot/tests/test_installer.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
from askbot.tests.utils import AskbotTestCase
from askbot.deployment import AskbotSetup
from askbot.deployment.parameters import *
from askbot.deployment.deployables import *
from askbot.deployment.parameters import askbotCollection, cacheManager,\
databaseManager, filesystemManager
from askbot.deployment.deployables import RenderedFile, CopiedFile, EmptyFile,\
Directory, LinkedDir, AskbotApp, AskbotSite, ProjectRoot
from unittest.mock import patch, MagicMock, mock_open

import tempfile
Expand Down

0 comments on commit fe1b221

Please sign in to comment.