Always remove fsck recovered files on boot

A recent change made the image cleanup conditional on successful archiving,
which had the unwanted side effect of no longer removing files recovered
by fsck when TeslaUSB boots, which apparently confuse the car.
Make it so that those file are removed again when TeslaUSB boots.

Author: marcone

run/archiveloop

@@ -356,17 +356,22 @@ function intersect {
 
 function clean_cam_mount {
 
-  if [ -e /tmp/last_clean_time ]
+  local mode="${1:-}"
+
+  if [ "$mode" = "freespace" ]
   then
-    read -r -d . last < /tmp/last_clean_time
-    read -r -d . now < /proc/uptime
-    if (( (now - last) < 300 ))
+    if [ -e /tmp/last_clean_time ]
     then
-      log "skipping cleaning cam mount"
-      return
+      read -r -d . last < /tmp/last_clean_time
+      read -r -d . now < /proc/uptime
+      if (( (now - last) < 300 ))
+      then
+        log "skipping cleaning cam mount"
+        return
+      fi
     fi
+    cat /proc/uptime > /tmp/last_clean_time
   fi
-  cat /proc/uptime > /tmp/last_clean_time
 
   log "cleaning cam mount"
   ensure_cam_file_is_mounted
@@ -378,26 +383,29 @@ function clean_cam_mount {
   # Delete short recordings
   (cd "${CAM_MOUNT}"; find . -type f -name \*.mp4 -size -100000c -printf '%P\n' ) | xargs rm -rf
 
-  # Remove files, oldest first, until there is at least 20GB of free space
-
-  (cd "${CAM_MOUNT}"; find . -type f -a \( -path './TeslaCam/*' -o -path './TeslaTrackMode/*' \) -printf '%P\0') > /tmp/rmcandidates.txt
-  if [ -s /tmp/rmcandidates.txt ]
+  if [ "$mode" = "freespace" ]
   then
-    (cd "${CAM_MOUNT}"; xargs -a /tmp/rmcandidates.txt -0 ls -cr1) > /tmp/rmcandidatesbytime.txt
-  else
-    true > /tmp/rmcandidatesbytime.txt
-  fi
-
-  local freespace
-  while read -r line
-  do
-    freespace=$(eval "$(stat --file-system --format="echo \$((%f*%S))" "${CAM_MOUNT}/.")")
-    if ((freespace > 20000000000))
+    # Remove files, oldest first, until there is at least 20GB of free space
+ 
+    (cd "${CAM_MOUNT}"; find . -type f -a \( -path './TeslaCam/*' -o -path './TeslaTrackMode/*' \) -printf '%P\0') > /tmp/rmcandidates.txt
+    if [ -s /tmp/rmcandidates.txt ]
     then
-      break;
+      (cd "${CAM_MOUNT}"; xargs -a /tmp/rmcandidates.txt -0 ls -cr1) > /tmp/rmcandidatesbytime.txt
+    else
+      true > /tmp/rmcandidatesbytime.txt
     fi
-    rm "${CAM_MOUNT}/$line"
-  done < /tmp/rmcandidatesbytime.txt
+ 
+    local freespace
+    while read -r line
+    do
+      freespace=$(eval "$(stat --file-system --format="echo \$((%f*%S))" "${CAM_MOUNT}/.")")
+      if ((freespace > 20000000000))
+      then
+        break;
+      fi
+      rm "${CAM_MOUNT}/$line"
+    done < /tmp/rmcandidatesbytime.txt
+  fi
 
   # delete directories that are now empty
   find "$CAM_MOUNT/TeslaCam/RecentClips" "$CAM_MOUNT/TeslaCam/SavedClips" \
@@ -634,7 +642,7 @@ function archive_teslacam_clips () {
   then
     if [ "$archive_success" = "true" ]
     then
-      clean_cam_mount
+      clean_cam_mount freespace
     else
       log "Skipping cleaning step after archive error"
     fi
@@ -852,6 +860,8 @@ logrotator &
 wifichecker &
 
 fix_errors_in_images
+# always remove files that fsck recoverd
+clean_cam_mount boot
 
 if has_cam_disk
 then