Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With introduction of base_bio_on, users may request fields that MARBL can not provide #452

Closed
mnlevy1981 opened this issue Jan 26, 2024 · 1 comment · Fixed by #453
Closed

With introduction of base_bio_on, users may request fields that MARBL can not provide #452

mnlevy1981 opened this issue Jan 26, 2024 · 1 comment · Fixed by #453
Assignees
@mnlevy1981

Comments

@mnlevy1981
Copy link
Collaborator

If the user requests a field that MARBL is not computing (e.g. requesting chlorophyll when base_bio_on = .false.), MARBL should abort. Currently, in that situation, get_output_for_GCM() returns 0 when the GCM really needs to be getting chlorophyll from a different source.
@mnlevy1981 mnlevy1981 self-assigned this Jan 26, 2024
@mnlevy1981 mnlevy1981 linked a pull request Jan 29, 2024 that will close this issue
Only allow GCM to request certain output fields if base_bio_on is True #453
Merged
@mnlevy1981
Copy link
Collaborator Author

Fixed by #453 (marbl0.46.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnlevy1981 mnlevy1981

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only allow GCM to request certain output fields if base_bio_on is True mnlevy1981/MARBL
1 participant
@mnlevy1981