Fix how userId fallback is used on username

mapswipe · Oct 28, 2024 · 5faf645 · 5faf645
1 parent 7ba2b5f
commit 5faf645
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/community-dashboard/app/components/ItemSelectInput/index.tsx b/community-dashboard/app/components/ItemSelectInput/index.tsx
@@ -192,7 +192,7 @@ function ItemSelectInput<Name extends string>(props: ItemSelectInputProps<Name>)
         () => ([
             ...(usersData?.map((user) => ({
                 id: user.userId,
-                name: (isFalsyString(user.username) ? user.userId : user.username) ?? 'Unknown',
+                name: (isFalsyString(user.username) ? user.userId : user.username),
                 type: 'user' as const,
             })) ?? []),
             ...(userGroupsData?.map((userGroup) => ({

diff --git a/community-dashboard/app/views/UserDashboard/index.tsx b/community-dashboard/app/views/UserDashboard/index.tsx
@@ -1,6 +1,6 @@
 import React, { useMemo } from 'react';
 import { gql, useQuery } from '@apollo/client';
-import { encodeDate, isDefined, isNotDefined } from '@togglecorp/fujs';
+import { encodeDate, isDefined, isFalsyString } from '@togglecorp/fujs';
 import { useParams, generatePath, Link } from 'react-router-dom';
 
 import useUrlState from '#hooks/useUrlState';
@@ -184,7 +184,7 @@ function UserDashboard(props: Props) {
     // NOTE: OSM user does not have username stored
     const userName = useMemo(() => {
         if (isDefined(userStats) && isDefined(userStats.user)) {
-            return isNotDefined(userStats.user.username)
+            return isFalsyString(userStats.user.username)
                 ? userStats.user.userId
                 : userStats.user.username;
         }