-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the description of mapping_provider
#400
Comments
Required by gbv/jskos#108 |
The current definition is:
Assuming you are both after a glass clear rationale why URL vs URI/RDFS resource. I personally wanted to keep this as open as possible. What I originally intended is of course using a resource id, like an infores CURIE (e.g. infores:go, ror:123), but for the groups I was working with it was too much of a barrier (like OHDSI) - they just simply would not fill in this field if I would ask for it to be a resources identifier. I dont know what is best... Opinions? |
The examples don't match the description "for example an ontology that already contains the mappings, or a database from which it was derived." Both https://www.ohdsi.org/ and https://monarchinitiative.org/ are projects/groups/initiatives that happen to publish ontologies or databases. My confusion is also about to mapping_source / mapping_set_source and how it relates to Reading the examples, I'd think that a |
Good point. The original use case for this field was to denote a resource, like "uniprot", OMOP vocabulary server, BARTOC etc, but it quickly devolved (probably due to the poor description) to be used for organisations. I think on average, this property was mostly used to denote the organisations providing the mappings.. Not sure what is best here, but maybe if we extend the definition towards including projects/groups/initiatives as well it would help? |
Yes, how about "URI/URL of the organization or service that provided the mappings, for example a publisher, repository or database from which they were derived" In JSKOS this would broadly be:
The question whether a specific database is more a "source" or more a "provider"/"publisher) can only be answered for the individual case. |
I like this. WIlling to make a PR? https://github.com/mapping-commons/sssom/blob/master/src/sssom_schema/schema/sssom_schema.yaml |
Originally posted by @cthoyt in #394 (comment)
The text was updated successfully, but these errors were encountered: