Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Changelog.md being chosen as a source for releases #1665

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Jan 26, 2025

both body_part and draft override the current text.
That is really annoying and must be a bug, but I don't think we need this functionality (do we?)

I don't know if we want generate_release_notes. I have added it, but we might not want this..

(and I should have used my fork, sorry)

@CommanderStorm CommanderStorm requested a review from nyurik January 26, 2025 16:40
@nyurik
Copy link
Member

nyurik commented Jan 26, 2025

tbh, i never used the auto-release tools (I would love to, just haven't had the brain capacity to go into it). I'm ok with whatever method tbh. Perhaps lets do v15 by hand, and merge this after?

@CommanderStorm
Copy link
Collaborator Author

CommanderStorm commented Jan 26, 2025

Perhaps lets do v15 by hand, and merge this after?

I don't think that will be possible as the action overrides the content of the release, and is triggered on-release.
Which makes it back to a draft with the wrong content.

(I honestly have no clue what I and you are doing differently that you are not triggering this part and I don't want to debug it ^^)

@CommanderStorm CommanderStorm merged commit f5c5d7c into main Jan 26, 2025
15 of 16 checks passed
@CommanderStorm CommanderStorm deleted the CommanderStorm-patch-1 branch January 26, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants