diff --git a/cpp/src/parquet/metadata.cc b/cpp/src/parquet/metadata.cc index b24883cdc160b..d7be50a6116bd 100644 --- a/cpp/src/parquet/metadata.cc +++ b/cpp/src/parquet/metadata.cc @@ -1360,9 +1360,9 @@ class ApplicationVersionParser { // For parsing. std::string spaces_; std::string digits_; - size_t version_parsing_position_; - size_t version_start_; - size_t version_end_; + size_t version_parsing_position_{0}; + size_t version_start_{0}; + size_t version_end_{0}; std::string version_string_; }; } // namespace diff --git a/cpp/src/parquet/schema.cc b/cpp/src/parquet/schema.cc index 4ddeef9e83975..47fa72d829658 100644 --- a/cpp/src/parquet/schema.cc +++ b/cpp/src/parquet/schema.cc @@ -600,7 +600,7 @@ class SchemaVisitor : public Node::ConstVisitor { void Visit(const Node* node) override { format::SchemaElement element; node->ToParquet(&element); - elements_->push_back(element); + elements_->push_back(std::move(element)); if (node->is_group()) { const GroupNode* group_node = static_cast(node); @@ -671,7 +671,7 @@ static void PrintType(const PrimitiveNode* node, std::ostream& stream) { static void PrintConvertedType(const PrimitiveNode* node, std::ostream& stream) { auto lt = node->converted_type(); - auto la = node->logical_type(); + const auto& la = node->logical_type(); if (la && la->is_valid() && !la->is_none()) { stream << " (" << la->ToString() << ")"; } else if (lt == ConvertedType::DECIMAL) { @@ -718,7 +718,7 @@ struct SchemaPrinter : public Node::ConstVisitor { stream_ << " group " << "field_id=" << node->field_id() << " " << node->name(); auto lt = node->converted_type(); - auto la = node->logical_type(); + const auto& la = node->logical_type(); if (la && la->is_valid() && !la->is_none()) { stream_ << " (" << la->ToString() << ")"; } else if (lt != ConvertedType::NONE) { diff --git a/cpp/src/parquet/schema.h b/cpp/src/parquet/schema.h index 896ec1e47968d..7163a03cf1adf 100644 --- a/cpp/src/parquet/schema.h +++ b/cpp/src/parquet/schema.h @@ -175,7 +175,7 @@ class PARQUET_EXPORT Node { Node::type type_; std::string name_; Repetition::type repetition_; - ConvertedType::type converted_type_; + ConvertedType::type converted_type_{ConvertedType::NONE}; std::shared_ptr logical_type_; int field_id_; // Nodes should not be shared, they have a single parent. @@ -280,7 +280,8 @@ class PARQUET_EXPORT GroupNode : public Node { const NodeVector& fields, std::shared_ptr logical_type, int field_id = -1) { - return NodePtr(new GroupNode(name, repetition, fields, logical_type, field_id)); + return NodePtr( + new GroupNode(name, repetition, fields, std::move(logical_type), field_id)); } bool Equals(const Node* other) const override; @@ -376,7 +377,7 @@ class PARQUET_EXPORT ColumnDescriptor { ColumnOrder column_order() const { return primitive_node_->column_order(); } SortOrder::type sort_order() const { - auto la = logical_type(); + const auto& la = logical_type(); auto pt = physical_type(); return la ? GetSortOrder(la, pt) : GetSortOrder(converted_type(), pt); } @@ -416,8 +417,8 @@ class PARQUET_EXPORT ColumnDescriptor { // TODO(wesm): this object can be recomputed from a Schema class PARQUET_EXPORT SchemaDescriptor { public: - SchemaDescriptor() {} - ~SchemaDescriptor() {} + SchemaDescriptor() = default; + ~SchemaDescriptor() = default; // Analyze the schema void Init(std::unique_ptr schema); @@ -464,7 +465,7 @@ class PARQUET_EXPORT SchemaDescriptor { // Root Node schema::NodePtr schema_; // Root Node - const schema::GroupNode* group_node_; + const schema::GroupNode* group_node_{nullptr}; void BuildTree(const schema::NodePtr& node, int16_t max_def_level, int16_t max_rep_level, const schema::NodePtr& base);