fix lint

mapleFU · Nov 12, 2024 · e9c550a · e9c550a
1 parent 22030db
commit e9c550a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/cpp/src/parquet/bloom_filter_builder.cc b/cpp/src/parquet/bloom_filter_builder.cc
@@ -145,11 +145,15 @@ void BloomFilterBuilderImpl::WriteTo(::arrow::io::OutputStream* sink,
       if (ARROW_PREDICT_FALSE(filter == nullptr)) {
         throw ParquetException("Bloom filter state is invalid for column ", column_id);
       }
+      if (ARROW_PREDICT_FALSE(column_id < 0 || column_id >= num_columns)) {
+        throw ParquetException("Invalid column ordinal when serailizing: ", column_id);
+      }
       PARQUET_ASSIGN_OR_THROW(int64_t offset, sink->Tell());
       filter->WriteTo(sink);
       PARQUET_ASSIGN_OR_THROW(int64_t pos, sink->Tell());
       if (pos - offset > std::numeric_limits<int32_t>::max()) {
-        throw ParquetException("Bloom filter is too large to be serialized.");
+        throw ParquetException("Bloom filter is too large to be serialized, size: ",
+                               pos - offset);
       }
       locations[column_id] = IndexLocation{offset, static_cast<int32_t>(pos - offset)};
     }

diff --git a/cpp/src/parquet/metadata.cc b/cpp/src/parquet/metadata.cc
@@ -1948,7 +1948,8 @@ class FileMetaDataBuilder::FileMetaDataBuilderImpl {
             const auto& row_group_bloom_filter_location = iter->second;
             for (auto& [column_id, bloom_filter_location] :
                  row_group_bloom_filter_location) {
-              DCHECK(column_id < row_group_metadata.columns.size());
+              DCHECK_LT(static_cast<size_t>(column_id),
+                        row_group_metadata.columns.size());
               auto& column = row_group_metadata.columns[column_id];
               auto& column_metadata = column.meta_data;
               column_metadata.__set_bloom_filter_offset(bloom_filter_location.offset);