Skip to content

Commit

Permalink
apacheGH-39384: [C++] Disable -Werror=attributes for Azure SDK's iden…
Browse files Browse the repository at this point in the history
…tity.hpp (apache#39448)

### Rationale for this change

Warnings in included headers are causing -Werror builds to fail.

### What changes are included in this PR?

Push and pop of ignore warning pragmas.

### Are these changes tested?

I'm asking @ anjakefala to test the build on this branch.
* Closes: apache#39384

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
  • Loading branch information
felipecrv authored Jan 5, 2024
1 parent 6c39726 commit 7b0c6f9
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions cpp/src/arrow/filesystem/azurefs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,16 @@
#include "arrow/filesystem/azurefs.h"
#include "arrow/filesystem/azurefs_internal.h"

// idenfity.hpp triggers -Wattributes warnings cause -Werror builds to fail,
// so disable it for this file with pragmas.
#if defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wattributes"
#endif
#include <azure/identity.hpp>
#if defined(__GNUC__)
#pragma GCC diagnostic pop
#endif
#include <azure/storage/blobs.hpp>
#include <azure/storage/files/datalake.hpp>

Expand Down

0 comments on commit 7b0c6f9

Please sign in to comment.