Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mapleFU committed Jan 15, 2025
1 parent 1c3ae5c commit 7714719
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cpp/src/parquet/column_writer_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1775,14 +1775,17 @@ TEST_F(TestInt32Writer, WriteKeyValueMetadataEndToEnd) {
}

TEST_F(TestValuesWriterInt32Type, AllNullsCompressionInPageV2) {
// GH-31992: In DataPageV2, the levels and data will not be compressed together,
// so, when all values are null, the compressed values should be empty. And
// we should handle this case correctly.
std::vector<Compression::type> compressions = {Compression::SNAPPY, Compression::GZIP,
Compression::ZSTD, Compression::BROTLI,
Compression::LZ4};
for (auto compression : compressions) {
if (!Codec::IsAvailable(compression)) {
continue;
}
SCOPED_TRACE(compression);
ARROW_SCOPED_TRACE("compression = ", Codec::GetCodecAsString(compression));
// Optional and non-repeated, with definition levels
// but no repetition levels
this->SetUpSchema(Repetition::OPTIONAL);
Expand Down

0 comments on commit 7714719

Please sign in to comment.