simplify compute

mapleFU · Jun 10, 2024 · 2907f23 · 2907f23
1 parent 98a4db8
commit 2907f23
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cpp/src/arrow/compute/expression.cc b/cpp/src/arrow/compute/expression.cc
@@ -763,9 +763,7 @@ Result<Datum> ExecuteScalarExpression(const Expression& expr, const ExecBatch& i
   for (size_t i = 0; i < arguments.size(); ++i) {
     ARROW_ASSIGN_OR_RAISE(
         arguments[i], ExecuteScalarExpression(call->arguments[i], input, exec_context));
-    if (!arguments[i].is_scalar()) {
-      all_scalar = false;
-    }
+    all_scalar &= arguments[i].is_scalar();
   }
 
   int64_t input_length;

diff --git a/cpp/src/arrow/compute/expression_test.cc b/cpp/src/arrow/compute/expression_test.cc
@@ -910,6 +910,8 @@ TEST(Expression, ExecuteCallWithNoArguments) {
 }
 
 TEST(Expression, ExecuteChunkedArray) {
+  // GH-41923: compute should generate the right result if input
+  // ExecBatch is `chunked_array`.
   auto input_schema = struct_({field("a", struct_({
                                               field("a", float64()),
                                               field("b", float64()),