Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in setting up repo locally #15

Open
imdhruvgupta opened this issue Feb 17, 2019 · 4 comments
Open

Issues in setting up repo locally #15

imdhruvgupta opened this issue Feb 17, 2019 · 4 comments

Comments

@imdhruvgupta
Copy link

imdhruvgupta commented Feb 17, 2019

The project contains sugarizer dependencies which are being imported in Sugarizer.js file.
webpage
But since the lib directory is outside of the src folder it is not allowed to import from it. A symlink of lib directory in src would suffice.

@imdhruvgupta
Copy link
Author

I have created a pull request - #16 (comment) .
Please review @llaske @manki11 .

@manki11
Copy link
Owner

manki11 commented Feb 17, 2019

You haven't followed "setting up the development environment" in the readme. After doing an npm install you need to copy the lib folder into the node_modules.

@imdhruvgupta
Copy link
Author

imdhruvgupta commented Feb 17, 2019

Hi @manki11 . Even after copying the lib folder in the node modules. I have to change the relative path of the imports in sugarizer.js file.
Won't it be better to have a symlink and have rather simpler process of setup? What do you say?

@siddhant1
Copy link

Will be solved by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants