[Lazy] Use host TERM #460
Merged
[Lazy] Use host TERM #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nervo
force-pushed
the
lazy/use_host_term
branch
from
8f711e7 to
78142fd
Compare
nervo
approved these changes
Oct 17, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass host TERM environment variable to system container, to benefit - among other things - from more colors in cli when available.
Note that OpenSSH does exactly the same when connecting to an another host.
Note also the default
xtermTERM we use; docker itself does the same: https://github.com/docker-archive/docker-ce/blob/7772923773ab88e8f7d20528a24f882014e0d8e4/components/engine/container/container.go#L736-L744