feat: add export flag to list command #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandrineP
added
the
release::enhancements
2 tasks
jjerphan
reviewed
Feb 4, 2025
libmamba/src/api/list.cpp
Outdated
| @@ -218,7 +219,11 @@ namespace mamba | |||
| { | |||
| if (options.canonical) | |||
| { | |||
| LOG_WARNING << "Option --canonical ignored because of --explicit"; | |||
| LOG_WARNING << "Option --canonical ignored because of --explicit \n"; | |||
There was a problem hiding this comment.
LOG_* add new lines implicitly.
Suggested change
| LOG_WARNING << "Option --canonical ignored because of --explicit \n"; | |
| LOG_WARNING << "Option --canonical ignored because of --explicit"; |
There was a problem hiding this comment.
Nitpick: this message might be slightly more explicit.
Suggested change
| LOG_WARNING << "Option --canonical ignored because of --explicit \n"; | |
| LOG_WARNING << "Option --canonical ignored because --explicit was provided"; |
libmamba/src/api/list.cpp
Outdated
| } | ||
| if (options.export_) | ||
| { | ||
| LOG_WARNING << "Option --export ignored because of --explicit \n"; |
There was a problem hiding this comment.
Suggested change
| LOG_WARNING << "Option --export ignored because of --explicit \n"; | |
| LOG_WARNING << "Option --export ignored because of --explicit"; |
libmamba/src/api/list.cpp
Outdated
| @@ -234,12 +239,23 @@ namespace mamba | |||
| } | |||
| else if (options.canonical) | |||
| { | |||
| if (options.export_) | |||
| { | |||
| LOG_WARNING << "Option --export ignored because of --explicit \n"; | |||
There was a problem hiding this comment.
Copy-paste mistake?
Suggested change
| LOG_WARNING << "Option --export ignored because of --explicit \n"; | |
| LOG_WARNING << "Option --export ignored because of --canonical"; |
micromamba/tests/test_list.py
Outdated
Comment on lines
120
to
127
| else: | ||
| if canonical_flag == "--canonical": | ||
| if canonical_flag in ["-c", "--canonical"]: | ||
| items = ["conda-forge/", "::"] | ||
| for output in outputs_list: | ||
| assert all(i in output for i in items) | ||
| assert " " not in output | ||
| else: | ||
| if export_flag in ["-e", "--export"]: |
There was a problem hiding this comment.
We can use elif twice instead here.
micromamba/tests/test_list.py
Outdated
Comment on lines
111
to
112
| outputs_list = [i for i in outputs_list if not i.startswith("Warning")] | ||
| outputs_list = [i for i in outputs_list if i != ""] |
There was a problem hiding this comment.
Suggested change
| outputs_list = [i for i in outputs_list if not i.startswith("Warning")] | |
| outputs_list = [i for i in outputs_list if i != ""] | |
| outputs_list = [i for i in outputs_list if i != "" and not i.startswith("Warning")] |
micromamba/tests/test_list.py
Outdated
Comment on lines
128
to
130
| items = ["conda-forge/", "::", " "] | ||
| for output in outputs_list: | ||
| # assert all(i not in output for i in items) |
There was a problem hiding this comment.
Suggested change
| items = ["conda-forge/", "::", " "] | |
| for output in outputs_list: | |
| # assert all(i not in output for i in items) | |
| items = ["conda-forge/", "::", " "] | |
| for output in outputs_list: | |
| assert all(i not in output for i in items) |
Also you might want to define items only once before the first if.
There was a problem hiding this comment.
Or alternatively:
Suggested change
| items = ["conda-forge/", "::", " "] | |
| for output in outputs_list: | |
| # assert all(i not in output for i in items) | |
| for output in outputs_list: |
micromamba/src/list.cpp
Outdated
| Configurable("export", false) | ||
| .group("cli") | ||
| .description( | ||
| "Output explicit, machine-readable requirement strings instead of human-readable lists of packages. Ignored if --explicit or --canonical." |
There was a problem hiding this comment.
Suggested change
| "Output explicit, machine-readable requirement strings instead of human-readable lists of packages. Ignored if --explicit or --canonical." | |
| "Output explicit, machine-readable requirement strings instead of human-readable lists of packages. Ignored if --explicit or --canonical is also provided." |
micromamba/tests/test_list.py
Outdated
| items = ["conda-forge/", "::", " "] | ||
| for output in outputs_list: | ||
| # assert all(i not in output for i in items) | ||
| assert output.count("=") == 2 |
There was a problem hiding this comment.
This is slightly more stricter.
Suggested change
| assert output.count("=") == 2 | |
| assert len(output.split("=")) == 3 |
JohanMabille
approved these changes
Feb 4, 2025
jjerphan
approved these changes
Feb 4, 2025
SandrineP
added a commit
to SandrineP/mamba
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds one of the missing sub-command #3535