New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(activedescendant): rollback scroll logic to use scrollTop #202

Merged

saiponnada merged 1 commit into master from scrollto-fix

Feb 27, 2025

Contributor

saiponnada commented Feb 27, 2025

Rolled back changes to previous state #175

Context

scrollIntoView is causing further issues with dependency libraries like floating-ui. Hence rolling back the changes to use previous implementation using scrollTo instead.
Previously this change was made because of the makeup listbox options not being focused when using kb with a long list whereas this was never an issue on ebayui-core.

Changes

Roll back changes to use scrollTo instead
Updated Listbox code to pass parentElement as container to active-descendant


          fix(activedescendant): rollback scroll logic to use scrollTop

5a097e0

saiponnada requested review from ianmcburnie and agliga

February 27, 2025 00:53

agliga approved these changes

View reviewed changes

Contributor

agliga left a comment

Good job!

saiponnada merged commit 4f1b96b into master

1 check failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet