Skip to content

Commit

Permalink
Remove check for ROCm 5.7.0. Test should fail instead.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 718549295
  • Loading branch information
nvgrw authored and tensorflower-gardener committed Jan 22, 2025
1 parent 8194e45 commit f7d3124
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
2 changes: 0 additions & 2 deletions third_party/xla/xla/tests/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -896,8 +896,6 @@ xla_test(
"//xla:types",
"//xla/hlo/builder:xla_builder",
"//xla/hlo/testlib:test",
"//xla/stream_executor:device_description",
"//xla/stream_executor:semantic_version",
"//xla/tsl/platform:statusor",
"//xla/tsl/platform:test",
"@com_google_absl//absl/base",
Expand Down
12 changes: 0 additions & 12 deletions third_party/xla/xla/tests/array_elementwise_ops_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ limitations under the License.
#include <string>
#include <tuple>
#include <utility>
#include <variant>
#include <vector>

#include "absl/base/casts.h"
Expand All @@ -43,8 +42,6 @@ limitations under the License.
#include "xla/literal.h"
#include "xla/literal_util.h"
#include "xla/primitive_util.h"
#include "xla/stream_executor/device_description.h"
#include "xla/stream_executor/semantic_version.h"
#include "xla/tests/client_library_test_runner_mixin.h"
#include "xla/tests/hlo_test_base.h"
#include "xla/tests/test_macros.h"
Expand Down Expand Up @@ -1744,15 +1741,6 @@ XLA_TEST_F(ArrayElementwiseOpTest, CompareLtU32s) {
}

XLA_TEST_F(ArrayElementwiseOpTest, PowF32s) {
auto device_description =
backend().default_stream_executor()->GetDeviceDescription();
bool is_rocm = std::holds_alternative<stream_executor::RocmComputeCapability>(
device_description.gpu_compute_capability());
if (is_rocm && device_description.runtime_version() ==
stream_executor::SemanticVersion(5, 7, 0)) {
GTEST_SKIP()
<< "This test fails on rocm-5.7.0 platform due to a compiler bug";
}
SetFastMathDisabled(true);
XlaBuilder builder(TestName());
auto eps = std::numeric_limits<float>::epsilon();
Expand Down

0 comments on commit f7d3124

Please sign in to comment.