Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from OSGeo:master #90

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 25, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

The update of OpenEXR in alpine:edge from 3.1.13-r2
(https://github.com/OSGeo/gdal/actions/runs/11960737896/job/33345432787)
to 3.3.2-r0
(https://github.com/OSGeo/gdal/actions/runs/12000822356/job/33450446198)
causes multiple tests to crash when reading pixels. This is apparently
linked to tiled files.

```
$ valgrind apps/gdallocationinfo temp.exr 0 0
Report:
  Location: (0P,0L)
  Band 1:
==96901== Invalid write of size 8
==96901==    at 0x11A9E833: ??? (in /usr/lib/libOpenEXRCore-3_3.so.32.3.3.2)
==96901==    by 0x11A9EFEC: ??? (in /usr/lib/libOpenEXRCore-3_3.so.32.3.3.2)
==96901==    by 0x11AA728A: exr_decoding_run (in /usr/lib/libOpenEXRCore-3_3.so.32.3.3.2)
==96901==    by 0xA2F275E: ??? (in /usr/lib/libOpenEXR-3_3.so.32.3.3.2)
==96901==    by 0xA2EFBFF: Imf_3_3::TiledInputFile::readTiles(int, int, int, int, int, int) (in /usr/lib/libOpenEXR-3_3.so.32.3.3.2)
==96901==    by 0xA2F2505: Imf_3_3::TiledInputFile::readTile(int, int, int, int) (in /usr/lib/libOpenEXR-3_3.so.32.3.3.2)
==96901==    by 0x59BE255: GDALEXRRasterBand::IReadBlock(int, int, void*) (in /home/even/gdal/gdal/build_ci_alpine/libgdal.so.36.3.11.0)
==96901==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==96901==
==96901==
==96901== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==96901==  Access not within mapped region at address 0x0
==96901==    at 0x11A9E833: ??? (in /usr/lib/libOpenEXRCore-3_3.so.32.3.3.2)
==96901==    by 0x11A9EFEC: ??? (in /usr/lib/libOpenEXRCore-3_3.so.32.3.3.2)
==96901==    by 0x11AA728A: exr_decoding_run (in /usr/lib/libOpenEXRCore-3_3.so.32.3.3.2)
==96901==    by 0xA2F275E: ??? (in /usr/lib/libOpenEXR-3_3.so.32.3.3.2)
==96901==    by 0xA2EFBFF: Imf_3_3::TiledInputFile::readTiles(int, int, int, int, int, int) (in /usr/lib/libOpenEXR-3_3.so.32.3.3.2)
==96901==    by 0xA2F2505: Imf_3_3::TiledInputFile::readTile(int, int, int, int) (in /usr/lib/libOpenEXR-3_3.so.32.3.3.2)
==96901==    by 0x59BE255: GDALEXRRasterBand::IReadBlock(int, int, void*) (in /home/even/gdal/gdal/build_ci_alpine/libgdal.so.36.3.11.0)
```
tests: skip tests that crash with OpenEXR 3.3.2
@pull pull bot added the ⤵️ pull label Nov 25, 2024
@pull pull bot merged commit d66e4db into makesoftwaresafe:master Nov 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12013397738

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 42 unchanged lines in 23 files lost coverage.
  • Overall coverage increased (+0.001%) to 73.702%

Files with Coverage Reduction New Missed Lines %
frmts/gtiff/libtiff/tif_read.c 1 66.77%
frmts/gtiff/gtiffdataset_read.cpp 1 91.02%
gcore/gdalrasterband.cpp 1 79.3%
port/cpl_minixml.cpp 1 88.49%
ogr/ogrlinestring.cpp 1 86.23%
port/cpl_vsil_curl_streaming.cpp 1 86.28%
frmts/gtiff/libtiff/tif_write.c 1 56.47%
gcore/rasterio.cpp 1 91.17%
frmts/vrt/vrtderivedrasterband.cpp 1 93.2%
port/cpl_error.cpp 1 70.5%
Totals Coverage Status
Change from base Build 12007103632: 0.001%
Covered Lines: 544555
Relevant Lines: 738863

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants