Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from OSGeo:master #153

Merged
merged 3 commits into from
Jan 15, 2025
Merged

[pull] master from OSGeo:master #153

merged 3 commits into from
Jan 15, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 15, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

…velope of a non-rectangle clip geometry, but doesn't intersect it (3.10.0 regression)

Fixes #11652
Fixes #10341

This fixes commit
388d3ae (PR #10341) "ogr2ogr: speed-up
-clipsrc/-clipdst by avoiding GEOS when possible", which only worked if
the clipping geometry was a rectangle.
ogr2ogr: fix -clipsrc/-clipdst when a input geometry is within the envelope of a non-rectangular clip geometry, but doesn't intersect it (3.10.0 regression)
@pull pull bot added the ⤵️ pull label Jan 15, 2025
@pull pull bot merged commit 8a81b58 into makesoftwaresafe:master Jan 15, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12791672886

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 24 of 32 (75.0%) changed or added relevant lines in 1 file are covered.
  • 66 unchanged lines in 30 files lost coverage.
  • Overall coverage decreased (-0.002%) to 70.095%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/ogr2ogr_lib.cpp 24 32 75.0%
Files with Coverage Reduction New Missed Lines %
gcore/gdal_priv_templates.hpp 1 93.57%
frmts/jpeg/jpgdataset.cpp 1 82.61%
port/cpl_string.cpp 1 89.51%
gcore/gdalrasterband.cpp 1 79.3%
frmts/gtiff/libtiff/tif_open.c 1 63.66%
port/cpl_minixml.cpp 1 87.86%
ogr/ogrsf_frmts/mitab/mitab_mapfile.cpp 1 74.1%
port/cpl_recode.cpp 1 84.0%
port/cpl_vsil.cpp 1 88.66%
gcore/rasterio.cpp 1 91.59%
Totals Coverage Status
Change from base Build 12780999953: -0.002%
Covered Lines: 563717
Relevant Lines: 804222

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants