Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lite PSM and Splitter emergency spells #2

Merged
merged 18 commits into from
Nov 11, 2024
Merged

Add Lite PSM and Splitter emergency spells #2

merged 18 commits into from
Nov 11, 2024

Conversation

oddaf
Copy link
Member

@oddaf oddaf commented Oct 1, 2024

No description provided.

@oddaf oddaf marked this pull request as ready for review October 1, 2024 19:29
@oddaf oddaf requested review from amusingaxl and 0xdecr1pto October 1, 2024 19:30
@amusingaxl amusingaxl changed the base branch from master to feat/add-spells October 2, 2024 12:39
amusingaxl
amusingaxl requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@amusingaxl amusingaxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. I made a couple of suggestions.

@DaiFoundation-DevOps
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@oddaf @amusingaxl
Update README.md
61bbd45 
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com>
Base automatically changed from feat/add-spells to master October 18, 2024 14:53
amusingaxl
amusingaxl requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@amusingaxl amusingaxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of suggestions.

@oddaf @amusingaxl
Update src/splitter-stop/SplitterStopSpell.sol
fab5046 
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com>
amusingaxl
amusingaxl approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@amusingaxl amusingaxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@amusingaxl amusingaxl requested a review from 0xp3th1um November 6, 2024 18:19
0xp3th1um
0xp3th1um approved these changes Nov 7, 2024
View reviewed changes
Copy link

@0xp3th1um 0xp3th1um left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@amusingaxl amusingaxl merged commit c02f3af into master Nov 11, 2024
1 check passed
@amusingaxl amusingaxl deleted the feat/psm-splitter-emergency-spells branch November 11, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amusingaxl amusingaxl amusingaxl approved these changes

@0xdecr1pto 0xdecr1pto 0xdecr1pto approved these changes

@0xp3th1um 0xp3th1um 0xp3th1um approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oddaf @DaiFoundation-DevOps @amusingaxl @0xdecr1pto @0xp3th1um