Add JVM metrics and plotting requests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btmonier
added
documentation
zrm22
reviewed
Oct 11, 2024
R/class_jvm_stats.R
Outdated
|
|
||
| # Get memory profile | ||
| runtime <- rJava::.jcall("java/lang/Runtime", "Ljava/lang/Runtime;", "getRuntime") | ||
| gbConv <- 1024 ^ 3 |
There was a problem hiding this comment.
Is there a reason to just not make 1073741824 the constant?
There was a problem hiding this comment.
Nope - just easier to remember
zrm22
approved these changes
Oct 11, 2024
lynnjo
reviewed
Oct 14, 2024
vignettes/rPHG2.Rmd
Outdated
| Since we need to construct an interface to a local instance of Java, errors | ||
| may arise due to several issues. Two common causes are version issues and | ||
| memory allocated to the JVM. For debugging and monitoring purposes, we can | ||
| use the `jvmStats()` function which create a instance of a `JvmStats` object. |
There was a problem hiding this comment.
should be "which creates". (add "s" to create)
lynnjo
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plotHaploCounts():geombuildHaplotypeGraph():and direct user to run
initPhg()JvmStats:session
jvmStats()constructor functioninitPhg()plotGvcf()function:colorOverride: Overrides bar color based on given user defined colorsampleOrder: Overrides default bar ordering based on user definedcharactervector