Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Dynamically set upward server variables #23126

Conversation

lewisvoncken
Copy link
Contributor

  • MAGENTO_BACKEND_URL based on HTTPS and HTTP_HOST
  • NODE_ENV based on MAGE_MODE

Description (*)

To run PWA Studio through Upward there are 2 variables which need to be set.
This PR is related to the upward-php PR magento/upward-php#65

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

 - MAGENTO_BACKEND_URL based on HTTPS and HTTP_HOST
 - NODE_ENV based on MAGE_MODE
@lewisvoncken lewisvoncken requested review from zetlen, ericerway and a user June 4, 2019 18:50
@m2-assistant
Copy link

m2-assistant bot commented Jun 4, 2019

Hi @lewisvoncken. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewisvoncken first of all, please provide comprehensive steps for this to be tested.

@ghost
Copy link

ghost commented Jun 5, 2019

@lewisvoncken I think we can add this to the magento2-upward-connector. And set the needed variables somewhere in the controller before initiation of the upward php

@orlangur
Copy link
Contributor

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.
Thanks for collaboration!

@orlangur orlangur closed this Jun 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2019

Hi @lewisvoncken, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants