Skip to content

Commit d534c61

Browse files
glo11372chetana11del22123
authored
Php version update to 8.4 (#25)
* Php version update to 8.4 * PWA-3372-Fixed PHP 8.4 compatability issues --------- Co-authored-by: chetana11 <cjain11.cj@gmail.com> Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>
1 parent 83e32ff commit d534c61

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Model/DataProvider/UrlRewrite/CatalogDataProvider.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ public function __construct(
2222
public function getData(
2323
string $entity_type,
2424
int $id,
25-
ResolveInfo $info = null,
26-
int $storeId = null
25+
?ResolveInfo $info = null,
26+
?int $storeId = null
2727
): array {
2828
$category = $this->categoryRepository->get($id, $storeId);
2929

Model/DataProvider/UrlRewrite/PageProvider.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ public function __construct(
2525
public function getData(
2626
string $entity_type,
2727
int $id,
28-
ResolveInfo $info = null,
29-
int $storeId = null
28+
?ResolveInfo $info = null,
29+
?int $storeId = null
3030
): array {
3131
$page = $this->pageRepository->getById($id);
3232

composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"sort-packages": true
66
},
77
"require": {
8-
"php": "~8.1.0||~8.2.0||~8.3.0",
8+
"php": "~8.2.0||~8.3.0||~8.4.0",
99
"magento/framework": "*",
1010
"magento/upward": "*",
1111
"magento/module-config": "*",

0 commit comments

Comments
 (0)