Remove icrate's custom macros #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
If `header-translator` will ever provide functionality to convert e.g. `Bool` to `bool` or `*mut` to `Id`, then that should be implemented inline, without the use of an extra macro (since that is also what we'd recommend a manual user to do).
`header-translator` may at some point provide functionality to mark external statics as safe, but then it should implement that without using a helper macro.
In the future, we may introduce a helper for deriving Encode and RefEncode, but for now this will: 1. Make it clearer in the source code what is actually happening. 2. Help users looking at `icrate` get a feel for how they should import external enums themselves.
madsmtm
force-pushed
the
trim-icrate-common
branch
from
2244325 to
e325239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #537.
To be able to split the frameworks out into separate crates, they each need to not depend on anything except
objc2,block2,dispatchand each other. This PR takes the first (big) step towards doing so, by removing the custom macros, and avoiding the use of the imports from thecommonmodule outside of auto-generated code.This makes the generated output more verbose, especially since we don't yet have
#[derive(Encode, RefEncode)](see #55), but should also make it easier for newcomers to understand what's going on (since it's "just" using the documentedobjc2macros).