Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't run Vim non-src tests (indent/syntax etc) #1541

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

ychin
Copy link
Member

@ychin ychin commented Feb 1, 2025

Currently Vim syntax tests are quite broken and keep failing in MacVim CI. There seems to be some Unicode / emoji handling bug causing tests to fail sporadically, and the syntax tests also spam the console output as they aren't redirecting output to /dev/null like normal Vim script tests. Just disable them for now until this is fixed.

This should not cause much issues anyway. It's unlike MacVim will have any downstream syntax/indent bugs as those files are mostly merged from upstream as-is.

Currently Vim syntax tests are quite broken and keep failing in MacVim
CI. There seems to be some Unicode / emoji handling bug causing tests to
fail sporadically, and the syntax tests also spam the console output as
they aren't redirecting output to /dev/null like normal Vim script
tests. Just disable them for now until this is fixed.

This should not cause much issues anyway. It's unlike MacVim will have
any downstream syntax/indent bugs as those files are mostly merged from
upstream as-is.
@ychin ychin added Infrastructure Non-app infrastructure issues, e.g. CI Non User Facing Non-user facing change. These issues do no need to show up in release notes. labels Feb 1, 2025
@ychin ychin added this to the Release 181 milestone Feb 1, 2025
@github-actions github-actions bot added the CI Vim upstream label for CI issues label Feb 1, 2025
@ychin ychin merged commit c8a844c into macvim-dev:master Feb 1, 2025
4 checks passed
@ychin ychin deleted the ci-dont-run-broken-vim-syntax-tests branch February 1, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Vim upstream label for CI issues Infrastructure Non-app infrastructure issues, e.g. CI Non User Facing Non-user facing change. These issues do no need to show up in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant