Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box constructor is type-unstable #57

Open
lmiq opened this issue Apr 1, 2022 · 0 comments
Open

Box constructor is type-unstable #57

lmiq opened this issue Apr 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@lmiq
Copy link
Member

lmiq commented Apr 1, 2022

The Box constructor is type-unstable, because of the two types of unit cells and the two dimensions that are possible.

This type instability is benign, as it does not propagate to the performance-critical functions, but anyway it is annoying sometimes, if it is being used from within a larger code base, because it causes some minor allocations.
@lmiq lmiq added the enhancement New feature or request label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmiq