feat: Continuous index across disabling/enabling of earning #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
PierrickGT
reviewed
Jan 24, 2025
| } | ||
|
|
||
| /// @inheritdoc IWrappedMToken | ||
| function startEarningFor(address account_) external { | ||
| if (!isEarningEnabled()) revert EarningIsDisabled(); |
There was a problem hiding this comment.
Shouldn't we still revert if earning is currently disabled?
There was a problem hiding this comment.
No. There is no harm to allowing starting earning when earning is disabled since when the index is continuous it will be fixed at whatever it is until earning is enabled again, and after that it will grow from that point when enabled.
deluca-mike
force-pushed
the
feat/no-claim-on-transfer-2
branch
from
ef65c39 to
482df44
Compare
deluca-mike
force-pushed
the
feat/continuous-index-2
branch
from
c64dd91 to
fcdd8b7
Compare
PierrickGT
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.