Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(interfaces): improve expiry doc #279

Merged
merged 1 commit into from
May 6, 2024
Merged

doc(interfaces): improve expiry doc #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/abstract/ERC5805.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ abstract contract ERC5805 is IERC5805, StatefulERC712 {
* @dev Returns the digest to be signed, via EIP-712, given an internal digest (i.e. hash struct).
* @param delegatee_ The address of the delegatee to delegate to.
* @param nonce_ The nonce of the account delegating.
* @param expiry_ The last timestamp at which the signature is still valid.
* @param expiry_ The timestamp until which the signature is still valid.
* @return The digest to be signed.
*/
function _getDelegationDigest(address delegatee_, uint256 nonce_, uint256 expiry_) internal view returns (bytes32) {
Expand Down
2 changes: 1 addition & 1 deletion src/abstract/interfaces/IERC5805.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ interface IERC5805 is IStatefulERC712, IERC6372 {
* @notice Changes the signing account's voting power delegation to `delegatee`.
* @param delegatee The address of the account the signing account's voting power will be delegated to.
* @param nonce The nonce of the account delegating.
* @param expiry The last block number where the signature is still valid.
* @param expiry The timestamp until which the signature is still valid.
* @param v A signature parameter.
* @param r A signature parameter.
* @param s A signature parameter.
Expand Down
4 changes: 2 additions & 2 deletions src/abstract/interfaces/IEpochBasedVoteToken.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ interface IEpochBasedVoteToken is IERC5805, IERC20Extended {
* @param account The purported address of the signing account.
* @param delegatee The address the voting power of `account` will be delegated to.
* @param nonce The nonce used for the signature.
* @param expiry The last block number where the signature is still valid.
* @param expiry The timestamp until which the signature is still valid.
* @param signature A byte array signature.
*/
function delegateBySig(
Expand All @@ -40,7 +40,7 @@ interface IEpochBasedVoteToken is IERC5805, IERC20Extended {
* @notice Returns the digest to be signed, via EIP-712, given an internal digest (i.e. hash struct).
* @param delegatee The address of the delegatee to delegate to.
* @param nonce The nonce of the account delegating.
* @param expiry The last timestamp at which the signature is still valid.
* @param expiry The timestamp until which the signature is still valid.
* @return The digest to be signed.
*/
function getDelegationDigest(address delegatee, uint256 nonce, uint256 expiry) external view returns (bytes32);
Expand Down
Loading