From 933543bd10ca9c6f24d22d31165049bfa9571848 Mon Sep 17 00:00:00 2001 From: Michael De Luca Date: Sat, 25 Nov 2023 04:53:49 -0500 Subject: [PATCH] fix: PR review fixes --- src/StandardGovernor.sol | 2 -- src/ZeroGovernor.sol | 6 ++---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/StandardGovernor.sol b/src/StandardGovernor.sol index 9d7eebc4..bfd6dd9f 100644 --- a/src/StandardGovernor.sol +++ b/src/StandardGovernor.sol @@ -17,9 +17,7 @@ import { IZeroToken } from "./interfaces/IZeroToken.sol"; // TODO: Determine standard way to inform externals about which token can vote. -// TODO: Expose `_proposals`? // TODO: Implement `QuorumNumeratorUpdated` (`quorumNumerator`, `quorumDenominator`) in the DualGovernor contract. -// TODO: Get rid of reasons and descriptions? Possibly even the exposed functions themselves. // TODO: Emit an event in the Governor or Power Token when a voter has voted on all standard proposals in an epoch. // TODO: Consider non-standard simplified versions of governor functions. diff --git a/src/ZeroGovernor.sol b/src/ZeroGovernor.sol index a7d1451f..f5dec948 100644 --- a/src/ZeroGovernor.sol +++ b/src/ZeroGovernor.sol @@ -22,16 +22,14 @@ contract ZeroGovernor is IZeroGovernor, ThresholdGovernor { ) ThresholdGovernor("ZeroGovernor", registrar_, voteToken_, thresholdRatio_) { if (allowedCashTokens_.length == 0) revert NoAllowedCashTokens(); + _startingCashToken = allowedCashTokens_[0]; + for (uint256 index_; index_ < allowedCashTokens_.length; ++index_) { address allowedCashToken_ = allowedCashTokens_[index_]; if (allowedCashToken_ == address(0)) revert InvalidCashTokenAddress(); _allowedCashTokens[allowedCashToken_] = true; - - if (index_ == 0) { - _startingCashToken = allowedCashToken_; - } } }