Skip to content

Update package.json to resolve depreciated warnings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mzvast
Copy link

@mzvast mzvast commented Jan 8, 2019

eliminate the warning of 'Tapable.plugin is deprecated. Use new API on .hooks instead'

@kopax
Copy link

kopax commented Dec 26, 2020

Hi, are you using this without problem ? Is this released? I am having a create-react-app with react-app-rewired and the current version does not compress anything.

@mzvast
Copy link
Author

mzvast commented Dec 26, 2020

Hi, are you using this without problem ? Is this released? I am having a create-react-app with react-app-rewired and the current version does not compress anything.

It’s not merged yet.
You can try install it right from my forked git repo
npm install git+https://github.com/mzvast/react-app-rewire-imagemin-plugin.git

@kopax
Copy link

kopax commented Dec 26, 2020

Using your plugin I have the same behavior with my create-react-app (react-scripts@4.0.1):

{
    {
      "options": {
        "disable": false,
        "maxConcurrency": 8,
        "imageminOptions": {
          "plugins": [
            null,
            null,
            null,
            null,
            null
          ]
        },
        "externalImages": {
          "context": ".",
          "sources": [],
          "destination": ".",
          "fileName": null
        },
        "cacheFolder": null
      }
    }
}

This is the part of configuration after I do :

writeFileSync('test.json', JSON.stringify(config, null, 2));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants