Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add person ID to profile [closes #597] #728

Merged
merged 7 commits into from
Feb 3, 2025
Merged

Add person ID to profile [closes #597] #728

merged 7 commits into from
Feb 3, 2025

Conversation

rpulkka
Copy link
Contributor

@rpulkka rpulkka commented Jan 29, 2025

#597
https://597.dev.laji.fi

This PR adds few UI changes:

  • Person ID is displayed next to user name
  • Profile settings link chapter is moved below title (previously it was below friends list)
  • Space between friend name and delete button
  • Translation for edit profile

@aorin aorin self-assigned this Jan 30, 2025
aorin
aorin approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@aorin aorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@Blodir Blodir added this to the Release 79 milestone Feb 3, 2025
@Blodir Blodir merged commit 94193d9 into development Feb 3, 2025
1 check passed
@Blodir Blodir deleted the profile-show-person-id-597 branch February 3, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aorin aorin aorin approved these changes

Assignees

@aorin aorin

Labels
None yet
Projects
None yet
Milestone
Release 79
Development

Successfully merging this pull request may close these issues.
3 participants
@rpulkka @aorin @Blodir