Skip to content

Remove unexpected reverse of button order in method select #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove unexpected reverse of button order in method select #51

wants to merge 3 commits into from

Conversation

EliasAAradsson
Copy link
Contributor

No description provided.

@bjornregnell
Copy link
Member

I think the buttons.reverse was there for a reason. Probably it was to make the selection of buttons bu index correct. If the reverse is removed, probably the indexing must also change, so that the chosen index is not subtracted or similar. Can you plese test so that many buttons get selected correctly based on what users click on after removing reverse?

EliasAAradsson and others added 2 commits November 17, 2024 22:49
@EliasAAradsson
Merge branch 'lunduniversity:master' into remove-button-reverse
72c2a86
@EliasAAradsson
Make method select nice
8ff117b 
Modify indexing in method `select` in order to match previous removal of reverse. Improve documentation of aforementioned method.
@EliasAAradsson
Copy link
Contributor Author

EliasAAradsson commented Nov 18, 2024 •
edited
Loading

I think the buttons.reverse was there for a reason. Probably it was to make the selection of buttons bu index correct. If the reverse is removed, probably the indexing must also change, so that the chosen index is not subtracted or similar. Can you plese test so that many buttons get selected correctly based on what users click on after removing reverse?

Now it should be ready for merge. (Fixed the above.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EliasAAradsson @bjornregnell