Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to listen on all ip addresses available #165

Open
GoogleCodeExporter opened this issue Oct 11, 2015 · 1 comment
Open

Allow to listen on all ip addresses available #165

GoogleCodeExporter opened this issue Oct 11, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

Mongoose allows to specify only port to listen on and in such case the web 
server should be listening on all ip addresses available (127.0.0.1, 
192.168.x.x, public..). Example from mongoose docs:

    listening_ports 8080,8043s 

(the second port is for SLL and is optional)

Currently phpdesktop forces a specific ip address be specified in 
settings.json. If the ip address is empty it assigns 127.0.0.1 by default.

It should be allowed for the ip address to be "*" and in such case set the 
listening_ports option in mongoose to contain only port.

Minor changes will be required in web_server.cpp:

https://code.google.com/p/phpdesktop/source/browse/phpdesktop-chrome/web_server.
cpp?r=c1ba05c26abf#59

https://code.google.com/p/phpdesktop/source/browse/phpdesktop-chrome/web_server.
cpp?r=c1ba05c26abf#161

Original issue reported on code.google.com by czarek.t...@gmail.com on 23 Apr 2015 at 10:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant