Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for torch state checking #6

Open
halileohalilei opened this issue Feb 6, 2018 · 4 comments
Open

Support for torch state checking #6

halileohalilei opened this issue Feb 6, 2018 · 4 comments

Comments

@halileohalilei
Copy link

The AVCaptureDevice API on iOS has a couple of methods like isTorchAvailable, isTorchActive and hasTorch for handling the torch. I haven't checked but I'm sure Android also has methods like these. It would be nice to see these methods implemented in react-native-torch, so that there would be no need for extra bridging to get the torch state from the native side.
@OlivierFreyssinet-old
Copy link

It would also be great to have support for something like onTorchModeChanged() https://developer.android.com/reference/android/hardware/camera2/CameraManager.TorchCallback.html#onTorchModeChanged(java.lang.String,%20boolean)

@oguennec
Copy link
Contributor

@ludo, @OlivierFreyssinet and @halileohalilei , I have submitted this PR which adds a Torch getStatus functionality as requested in this thread.

@elrhomariyounes
Copy link

elrhomariyounes commented May 27, 2020 •
edited
Loading

Please merge the @oguennec PR

@saberothmane
Copy link

@oguennec PR needed to merge please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@halileohalilei @oguennec @OlivierFreyssinet-old @saberothmane @elrhomariyounes and others