Change signature of onRemove to forward job result (#32)

lucas34 · Dec 14, 2017 · bab6ab9 · bab6ab9
1 parent e551db3
commit bab6ab9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/Sources/SwiftQueue/Job.swift b/Sources/SwiftQueue/Job.swift
@@ -125,6 +125,6 @@ public protocol Job {
     func onRetry(error: Swift.Error) -> RetryConstraint
 
     /// Job is removed from the queue and will never run again
-    func onRemove(error: Swift.Error?)
+    func onRemove(result: JobCompletion)
 
 }
diff --git a/Sources/SwiftQueue/SwiftQueueJob.swift b/Sources/SwiftQueue/SwiftQueueJob.swift
@@ -76,7 +76,7 @@ internal final class SwiftQueueJob: Operation, JobResult {
     internal func abort(error: Swift.Error) {
         lastError = error
         // Need to be called manually since the task is actually not in the queue. So cannot call cancel()
-        handler.onRemove(error: error)
+        handler.onRemove(result: .fail(error))
     }
 
     internal func run() {
@@ -105,7 +105,8 @@ internal final class SwiftQueueJob: Operation, JobResult {
     }
 
     internal func remove() {
-        handler.onRemove(error: lastError)
+        let result = lastError.map(JobCompletion.fail) ?? JobCompletion.success
+        handler.onRemove(result: result)
     }
 
     func done(_ result: JobCompletion) {

diff --git a/Tests/SwiftQueueTests/TestUtils.swift b/Tests/SwiftQueueTests/TestUtils.swift
@@ -43,13 +43,18 @@ class TestJob: Job {
         return retryConstraint
     }
 
-    func onRemove(error: Error?) {
-        if error == nil {
+    func onRemove(result: JobCompletion) {
+        switch result {
+        case .success:
             onCompleteCalled += 1
             semaphore.signal()
-        } else {
+            break
+
+        case .fail:
             onCancelCalled += 1
             semaphore.signal()
+            break
+
         }
     }