Fixes #749 - System.NotImplementedException when trying to call Prelo…

…adAsync
luberda-molinet · Oct 2, 2017 · d2b8ad5 · d2b8ad5
1 parent f90b5da
commit d2b8ad5
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/source/FFImageLoading.Common/Work/Target.cs b/source/FFImageLoading.Common/Work/Target.cs
@@ -3,14 +3,14 @@
 namespace FFImageLoading.Work
 {
     public class Target<TImageContainer, TImageView>: ITarget<TImageContainer, TImageView>
-	{
-        public virtual TImageView Control { get { throw new NotImplementedException(); }}
+    {
+        public virtual TImageView Control => default(TImageView);
 
-		public virtual bool IsValid { get; } = true;
+        public virtual bool IsValid { get; } = true;
 
         public virtual bool IsTaskValid(IImageLoaderTask task) => IsValid;
 
-		public virtual bool UsesSameNativeControl(IImageLoaderTask task) => false;
+        public virtual bool UsesSameNativeControl(IImageLoaderTask task) => false;
 
         public virtual void SetAsEmpty(IImageLoaderTask task) {  }
 

diff --git a/source/FFImageLoading.Common/Work/TaskParameter.cs b/source/FFImageLoading.Common/Work/TaskParameter.cs
@@ -180,7 +180,25 @@ public static TaskParameter FromString(string data, DataEncodingType encoding)
         /// <value>The delay in milliseconds.</value>
         public int? DelayInMs { get; private set; }
 
-        public bool Preload { get; internal set; }
+        bool preload;
+        public bool Preload
+        {
+            get
+            {
+                return preload;
+            }
+
+            internal set
+            {
+                preload = value;
+
+                if (value)
+                {
+                    FadeAnimationEnabled = false;
+                    FadeAnimationForCachedImagesEnabled = false;
+                }
+            }
+        }
 
         public TaskParameter Transform(ITransformation transformation)
         {