Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOTFIX-95] Fix for normalizer issue #21

Merged
merged 4 commits into from
Jan 27, 2025
Merged

[SOTFIX-95] Fix for normalizer issue #21

merged 4 commits into from
Jan 27, 2025

Conversation

alsoto25
Copy link
Contributor

@alsoto25 alsoto25 commented Jan 23, 2025 •
edited
Loading

Description

Addressing normalizer issue by removing incorrect condition.

Related Issue

#20

Type of Change / Changes Made

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing guidelines
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes do not introduce any new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@alsoto25 alsoto25 added the bug Something isn't working label Jan 23, 2025
@alsoto25 alsoto25 self-assigned this Jan 23, 2025
eric-bv
eric-bv approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@eric-bv eric-bv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for fixing this

@alsoto25 alsoto25 changed the title Fix for normalizer issue [SOTFIX-95] Fix for normalizer issue Jan 23, 2025
@Brian06 Brian06 merged commit 3e84bc9 into ltvco:main Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brian06 Brian06 Brian06 approved these changes

@eric-bv eric-bv eric-bv approved these changes

@KennethCalvo KennethCalvo Awaiting requested review from KennethCalvo KennethCalvo is a code owner

Assignees

@alsoto25 alsoto25

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alsoto25 @Brian06 @eric-bv