Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BINARY Vector #59

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Add support for BINARY Vector #59

merged 4 commits into from
Sep 29, 2024

Conversation

lovetodream
Copy link
Owner

No description provided.

@lovetodream lovetodream added the semver-minor Adds new public API. label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 96.70330% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.24%. Comparing base (cbedc27) to head (8bc2545).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OracleNIO/Data/OracleVector.swift 92.53% 5 Missing ⚠️
Tests/IntegrationTests/VectorTests.swift 95.77% 3 Missing ⚠️
...ources/OracleNIO/Data/JSON/OracleJSONStorage.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   87.08%   87.24%   +0.16%     
==========================================
  Files         140      141       +1     
  Lines       19145    19348     +203     
==========================================
+ Hits        16673    16881     +208     
+ Misses       2472     2467       -5     
Flag Coverage Δ
87.24% <96.70%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Sources/OracleNIO/Capabilities.swift 94.07% <100.00%> (+0.08%) ⬆️
...rces/OracleNIO/Data/JSON/OracleJSON+Decoding.swift 99.12% <100.00%> (+0.01%) ⬆️
...rces/OracleNIO/Data/JSON/OracleJSON+Encoding.swift 95.01% <100.00%> (+0.06%) ⬆️
Sources/OracleNIO/Data/JSON/OracleJSONParser.swift 95.12% <100.00%> (+0.07%) ⬆️
Sources/OracleNIO/Data/JSON/OracleJSONWriter.swift 93.06% <100.00%> (+0.07%) ⬆️
Tests/IntegrationTests/OracleNIOTests.swift 99.80% <100.00%> (-0.02%) ⬇️
...s/OracleNIOTests/Data/OracleJSONDecoderTests.swift 100.00% <100.00%> (ø)
...s/OracleNIOTests/Data/OracleJSONEncoderTests.swift 100.00% <100.00%> (ø)
...ts/OracleNIOTests/Data/OracleJSONParserTests.swift 100.00% <100.00%> (ø)
...ts/OracleNIOTests/Data/OracleJSONWriterTests.swift 100.00% <100.00%> (ø)
... and 4 more

... and 4 files with indirect coverage changes

@lovetodream lovetodream merged commit 5487c67 into main Sep 29, 2024
8 checks passed
@lovetodream lovetodream deleted the binary-vector branch September 29, 2024 14:22
@cjbj
Copy link

cjbj commented Sep 30, 2024

Thanks for adding this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants