Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public column metadata to Cursor #34

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

lovetodream
Copy link
Owner

closes #31

@lovetodream lovetodream added the semver-minor Adds new public API. label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 95.17045% with 17 lines in your changes missing coverage. Please review.

Project coverage is 76.95%. Comparing base (94de1ac) to head (a7445a3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   76.57%   76.95%   +0.38%     
==========================================
  Files         111      113       +2     
  Lines       13269    13445     +176     
==========================================
+ Hits        10161    10347     +186     
+ Misses       3108     3098      -10     
Files Coverage Δ
Sources/OracleNIO/Data/Cursor.swift 68.96% <100.00%> (+1.10%) ⬆️
...s/ByteBuffer/ByteBuffer+ReadStringWithFormat.swift 90.00% <100.00%> (ø)
Sources/OracleNIO/Helper/Crypto.swift 100.00% <100.00%> (ø)
...Messages/Coding/OracleFrontendMessageEncoder.swift 79.56% <ø> (-0.10%) ⬇️
...eNIO/Messages/OracleBackendMessage+Parameter.swift 55.23% <100.00%> (-3.74%) ⬇️
Sources/OracleNIO/OracleRow.swift 0.00% <ø> (ø)
Sources/OracleNIO/OracleRowSequence.swift 98.41% <ø> (ø)
Sources/OracleNIO/OracleRowStream.swift 58.06% <ø> (ø)
Sources/OracleNIO/Pool/OracleClient.swift 86.36% <100.00%> (ø)
Sources/OracleNIO/VariadicGenerics.swift 88.29% <ø> (ø)
... and 10 more

... and 2 files with indirect coverage changes

@lovetodream lovetodream merged commit 90e89e8 into main Jun 19, 2024
7 checks passed
@lovetodream lovetodream deleted the feature/expose-column-metadata2 branch June 19, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need "cursor.description" or something similar to get the column names.
1 participant