Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public column metadata to Cursor #33

Closed
wants to merge 3 commits into from

Conversation

lovetodream
Copy link
Owner

closes #31

* fix: improve error for unsupported oracle server version

* test: fix failure
@lovetodream lovetodream added the semver-minor Adds new public API. label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 67.92453% with 51 lines in your changes missing coverage. Please review.

Project coverage is 74.80%. Comparing base (4c3bd5e) to head (77efa3c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   76.53%   74.80%   -1.73%     
==========================================
  Files         111      111              
  Lines       13251    13270      +19     
==========================================
- Hits        10141     9926     -215     
- Misses       3110     3344     +234     
Files Coverage Δ
...onnectionStateMachine/ConnectionStateMachine.swift 70.39% <ø> (-0.03%) ⬇️
...ectionStateMachine/ExtendedQueryStateMachine.swift 74.76% <ø> (-2.66%) ⬇️
.../Messages/Coding/OracleBackendMessageDecoder.swift 87.82% <100.00%> (+0.21%) ⬆️
...Messages/Coding/OracleFrontendMessageEncoder.swift 77.03% <ø> (-2.63%) ⬇️
...acleNIO/Messages/OracleBackendMessage+Accept.swift 100.00% <100.00%> (ø)
Sources/OracleNIO/OracleRow.swift 0.00% <ø> (ø)
Sources/OracleNIO/OracleRowSequence.swift 98.41% <ø> (ø)
Sources/OracleNIO/OracleRowStream.swift 56.18% <ø> (-1.89%) ⬇️
Sources/OracleNIO/VariadicGenerics.swift 88.29% <ø> (ø)
Tests/OracleNIOTests/CapabilitiesTests.swift 100.00% <100.00%> (ø)
... and 3 more

... and 10 files with indirect coverage changes

@lovetodream
Copy link
Owner Author

messed up commits, continuing here #34

@lovetodream lovetodream deleted the feature/expose-column-metadata branch June 17, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need "cursor.description" or something similar to get the column names.
1 participant