Feature/custom view indicator #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified RCPageControl to handle creation of custom views instead of the current default UIView. Added happy/sad icon assets for example project.
|
Done right, I'll check it later. Thx! |
|
I think we should use a protocol instead of declaring an abstract class. Using |
|
Yeah, I agree, A protocol would be a better approach. Will get onto as soon as I get a free moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
Think this is way the best custom page control that I found on Cocoapods. Really like the use of pop for the animations.
Anyway I've added support so that the user can customise the indicator with a custom view (whilst keeping to the current project architecture and coding style). I've updated the example project to show how the user can initialise a RCPageControl with custom indicator views and also how to customise the views for both default and current states.
Let me know what you think.
Cheers
++