Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack migration from v1 upload #655

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

phillipperalez
Copy link
Collaborator

@phillipperalez phillipperalez commented Mar 4, 2025

This is currently a breaking change requiring channel:manage, im:write,mpim:write, and groups:write added to the scope permissions

Managed to rewrite in a way that requires no scope creep. If you pass a UXXXX token to chat.postMessage() you will receive an implicit conversion to direct message token types (DXXXXX). This was not documented by slack documentation.

This is to prevent outages from slack turning off the legacy V1 upload
endpoint
@phillipperalez phillipperalez requested a review from a team as a code owner March 4, 2025 19:21
@@ -167,40 +166,59 @@ export const handleExecute = async (request: Hub.ActionRequest, slack: WebClient
{webhookId},
)

// Unfortunately UploadV2 does not provide a way to upload files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment now defunct? Do we have a way to upload files to user tokens with UploadV2 now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't, we have a way to convert the tokens though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants