Skip to content

Adding SunSpec storage 124 Model #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 9, 2025

Conversation

CpuID
Copy link
Contributor

@CpuID CpuID commented Apr 7, 2025

Whoops typo'ed model in the commit message :)

Preparation for being able to work on #68 and #8

Derived from https://github.com/sunspec/models/blob/master/json/model_124.json

@CpuID CpuID marked this pull request as ready for review April 8, 2025 21:06
@CpuID
Copy link
Contributor Author

CpuID commented Apr 8, 2025

I thought I'd do this in multiple stages to make the review process easier.

My next goal was to handle the s/limiters/setpoints rename mentioned #68 (comment) as a separate PR, then we can start diving into what #68 starts to look like :)

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@longzheng longzheng merged commit 048101a into longzheng:main Apr 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants