Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HashMap with BTreeMap to remove non-determinism in build #104

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Feb 19, 2025

Addresses #103

with this change, on the reproducer I manage to get same hash on different builds

$ cargo -q clean ; cargo build -q --release ; sha1sum target/release/rust_i18n_repro_test
7b8d9cfbba8bd69ff03929f023e62ea125a9143d  target/release/rust_i18n_repro_test

$ cargo -q clean ; cargo build -q --release ; sha1sum target/release/rust_i18n_repro_test 
7b8d9cfbba8bd69ff03929f023e62ea125a9143d  target/release/rust_i18n_repro_test

@huacnlee huacnlee merged commit 0927768 into longbridge:main Feb 20, 2025
2 checks passed
@huacnlee
Copy link
Member

Thank you for deep analysis for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants