dont copy window filter every iteration

lolepop · Jan 13, 2022 · 5ad9d24 · 5ad9d24
1 parent 916bb8a
commit 5ad9d24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/native.cpp b/src/native.cpp
@@ -38,7 +38,7 @@ std::unordered_set<std::string> Native::getAllWindows()
     return windows;
 }
 
-bool Native::isWindowOpen(std::vector<std::string> filter)
+bool Native::isWindowOpen(const std::vector<std::string>& filter)
 {
     auto windows = getAllWindows();
     for (auto i = filter.begin(); i != filter.end(); i++)
@@ -129,7 +129,7 @@ std::unordered_set<std::string> Native::getAllWindows()
     return o;
 }
 
-bool Native::isWindowOpen(std::vector<std::string> filter)
+bool Native::isWindowOpen(const std::vector<std::string>& filter)
 {
     std::wstring_convert<std::codecvt_utf8<wchar_t>, wchar_t> converter;
     std::unordered_set<std::wstring> f;
@@ -208,7 +208,7 @@ std::unordered_set<std::string> Native::getAllWindows()
     return windows;
 }
 
-bool Native::isWindowOpen(std::vector<std::string> filter)
+bool Native::isWindowOpen(const std::vector<std::string>& filter)
 {
     std::unordered_set<std::wstring> f;
     std::wstring_convert<std::codecvt_utf8<wchar_t>, wchar_t> converter;

diff --git a/src/native.h b/src/native.h
@@ -9,5 +9,5 @@
 namespace Native
 {
     std::unordered_set<std::string> getAllWindows();
-    bool isWindowOpen(std::vector<std::string> filter);
+    bool isWindowOpen(const std::vector<std::string>& filter);
 }