Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook event types #442

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Webhook event types #442

merged 2 commits into from
Mar 19, 2024

Conversation

bodrovis
Copy link
Collaborator

Closes #440

@@ -1,5 +1,9 @@
# Changelog

## 13.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why semver major?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually now entirely sure. This is a new feature, not anything breaking, so theoretically we could mark it as 12.x. Still, this is a relatively "big" thing. In any case, this pr is not finalized, I'll need support from someone who could check if any fields are missing from these schemas

Copy link
Collaborator

@kibertoad kibertoad Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'd recommend semver minor for non-breaking incremental additions, it's easier to adopt for teams

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@bodrovis bodrovis merged commit c2709d7 into master Mar 19, 2024
7 of 8 checks passed
@bodrovis bodrovis deleted the webhook_types branch March 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing type definitions for webhook events
2 participants