Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 11.14.0 CHANGELOG PR link #1122

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Fix 11.14.0 CHANGELOG PR link #1122

merged 3 commits into from
Mar 22, 2023

Conversation

edmocosta
Copy link
Contributor

Fixed the 11.14.0 changelog entry, the correct PR link is #1118 instead of #1115.

#1118 (comment)

@edmocosta edmocosta self-assigned this Mar 22, 2023
@edmocosta edmocosta requested a review from andsel March 22, 2023 10:19
andsel
andsel requested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the reference to this PR into the new changelog line

CHANGELOG.md Outdated Show resolved Hide resolved
@edmocosta @andsel
Update CHANGELOG.md
f9c18e3 
Co-authored-by: Andrea Selva <selva.andre@gmail.com>
@edmocosta edmocosta requested a review from andsel March 22, 2023 12:24
andsel
andsel approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edmocosta edmocosta merged commit a0b4832 into logstash-plugins:main Mar 22, 2023
@edmocosta edmocosta deleted the fix_changelog_pr_link branch March 22, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andsel andsel andsel approved these changes

Assignees

@edmocosta edmocosta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmocosta @andsel @roaksoax