-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't delete rows from table component properly #212
Comments
@markconroy this popped up just now, think you've been talking about it on Slack Can you replicate/ attempt a fix? |
Thanks for sharing @RyanFH257 |
Any update please @markconroy? Thanks |
I couldn't replicate the issue when I tried back in December. I can try again, but I have a feeling fixing this will be for a backend developer rather than a frontend one. |
@ekes can you replicate this please? It's been an issue since November so would be good to track down/ fix if possible. Thanks! |
I did need to dig that video out to understand what was going on; but from that it became obvious that it's not renumbering the rows properly on changing the order. Which would be: https://www.drupal.org/project/tablefield/issues/3441319 I've tested the patch, and solved it for me. The issue will be getting the correct patch to version. I've just done it with the dev version of the module for now. Will check. |
Cheers Ekes, do you think we could get a fix for this sometime next week? How much effort do you think is left? Many thanks! |
Current patch only against this version. Haven't updated to the latest dev / rc because there seems to be some back and forth. Issue https://www.drupal.org/project/tablefield/issues/3441319 has branch that's up to date for dev.
Current patch only against this version. Haven't updated to the latest dev / rc because there seems to be some back and forth. Issue https://www.drupal.org/project/tablefield/issues/3441319 has branch that's up to date for dev.
This issue has been experienced by several councils (H&F, Blackburn and Bracknell Forest).
Sarah at Blackburn has also recorded a video - https://localgovdrupal.slack.com/archives/C020SJRQX2M/p1732872095512149
In my experience, I have been in the process of updating a table and needed to remove a few empty rows.
Steps taken:
Move the unwanted rows to the bottom of the table
Reduce the rows needed in the table
Click 'Rebuild table'
Outcome: Rows are deleted from the middle of the table
In the screenshots, the rows I have moved are:
Saturday 19 October 2024
Monday 4 November 2024 (8pm)
Saturday 23 November 2024
Thursday 5 December 2024 (7:30pm)
Sunday 8 December 2024 (2pm)
The rows that have been deleted are:
Sunday 26 January 2025 (12pm)
Saturday 15 February 2025
Saturday 22 February 2025
Saturday 15 March 2025
Saturday 5 April 2025
The text was updated successfully, but these errors were encountered: