Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete rows from table component properly #212

Open
RyanFH257 opened this issue Dec 19, 2024 · 7 comments
Open

Can't delete rows from table component properly #212

RyanFH257 opened this issue Dec 19, 2024 · 7 comments

Comments

@RyanFH257
Copy link

This issue has been experienced by several councils (H&F, Blackburn and Bracknell Forest).

Sarah at Blackburn has also recorded a video - https://localgovdrupal.slack.com/archives/C020SJRQX2M/p1732872095512149

In my experience, I have been in the process of updating a table and needed to remove a few empty rows.

Steps taken:

Move the unwanted rows to the bottom of the table
Reduce the rows needed in the table
Click 'Rebuild table'

Outcome: Rows are deleted from the middle of the table

In the screenshots, the rows I have moved are:

Saturday 19 October 2024
Monday 4 November 2024 (8pm)
Saturday 23 November 2024
Thursday 5 December 2024 (7:30pm)
Sunday 8 December 2024 (2pm)

The rows that have been deleted are:

Sunday 26 January 2025 (12pm)
Saturday 15 February 2025
Saturday 22 February 2025
Saturday 15 March 2025
Saturday 5 April 2025

Image

Image

@willguv
Copy link
Member

willguv commented Dec 19, 2024

@markconroy this popped up just now, think you've been talking about it on Slack

Can you replicate/ attempt a fix?

@willguv
Copy link
Member

willguv commented Dec 19, 2024

Thanks for sharing @RyanFH257

@markconroy markconroy self-assigned this Jan 15, 2025
@willguv
Copy link
Member

willguv commented Jan 22, 2025

Any update please @markconroy? Thanks

@markconroy
Copy link
Member

I couldn't replicate the issue when I tried back in December.

I can try again, but I have a feeling fixing this will be for a backend developer rather than a frontend one.

@markconroy markconroy removed their assignment Jan 22, 2025
@willguv
Copy link
Member

willguv commented Jan 23, 2025

@ekes can you replicate this please? It's been an issue since November so would be good to track down/ fix if possible. Thanks!

@ekes
Copy link
Member

ekes commented Jan 24, 2025

I did need to dig that video out to understand what was going on; but from that it became obvious that it's not renumbering the rows properly on changing the order. Which would be:

https://www.drupal.org/project/tablefield/issues/3441319

I've tested the patch, and solved it for me. The issue will be getting the correct patch to version. I've just done it with the dev version of the module for now. Will check.

@ekes ekes transferred this issue from localgovdrupal/localgov Jan 24, 2025
@willguv
Copy link
Member

willguv commented Jan 24, 2025

Cheers Ekes, do you think we could get a fix for this sometime next week? How much effort do you think is left? Many thanks!

ekes added a commit that referenced this issue Jan 24, 2025
Current patch only against this version. Haven't updated to the latest
dev / rc because there seems to be some back and forth. Issue
https://www.drupal.org/project/tablefield/issues/3441319 has branch
that's up to date for dev.
@ekes ekes moved this from Ready to In Progress - Core team in 2025 backlog Jan 30, 2025
@willguv willguv moved this from In Progress - Core team to Review in 2025 backlog Jan 30, 2025
ekes added a commit that referenced this issue Feb 4, 2025
Current patch only against this version. Haven't updated to the latest
dev / rc because there seems to be some back and forth. Issue
https://www.drupal.org/project/tablefield/issues/3441319 has branch
that's up to date for dev.
@ekes ekes mentioned this issue Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

No branches or pull requests

4 participants